Generate: handle logits_warper update in models with custom generate fn
#31957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
approved these changes
Jul 15, 2024
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Jul 16, 2024
…e fn (huggingface#31957) handle logits_warper update in models with custom generate fn
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Jul 19, 2024
…e fn (huggingface#31957) handle logits_warper update in models with custom generate fn
MHRDYN7
pushed a commit
to MHRDYN7/transformers
that referenced
this pull request
Jul 23, 2024
…e fn (huggingface#31957) handle logits_warper update in models with custom generate fn
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Jul 24, 2024
…e fn (huggingface#31957) handle logits_warper update in models with custom generate fn
itazap
pushed a commit
that referenced
this pull request
Jul 25, 2024
…e fn (#31957) handle logits_warper update in models with custom generate fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Oops, #31956 written by me broke some models with custom
generateloop (logits_warperis no longer optional).This PR corrects failing models, and takes the opportunity to standardize (i.e. copy-paste patterns)
generateon musicgen models.cc @ylacombe